fix model group auto-deletion when last version is deleted #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com>
rbhavna
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
rbhavna
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
rbhavna
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
rbhavna
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Codecov Report
@@ Coverage Diff @@
## 2.x #1444 +/- ##
============================================
- Coverage 78.41% 78.39% -0.02%
+ Complexity 2387 2379 -8
============================================
Files 196 196
Lines 9622 9591 -31
Branches 961 955 -6
============================================
- Hits 7545 7519 -26
+ Misses 1640 1637 -3
+ Partials 437 435 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
b4sjoo
previously approved these changes
Oct 6, 2023
Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com>
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com>
rbhavna
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
rbhavna
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
rbhavna
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
rbhavna
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
dhrubo-os
approved these changes
Oct 6, 2023
b4sjoo
approved these changes
Oct 6, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 6, 2023
* fix model group auto-deletion when last version is deleted Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com> (cherry picked from commit 1f43b28)
rbhavna
added a commit
that referenced
this pull request
Oct 6, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 16, 2023
* fix model group auto-deletion when last version is deleted Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com> (cherry picked from commit 1f43b28)
ylwu-amzn
pushed a commit
that referenced
this pull request
Oct 17, 2023
TrungBui59
pushed a commit
to TrungBui59/ml-commons
that referenced
this pull request
Nov 21, 2023
…h-project#1444) (opensearch-project#1523) * fix model group auto-deletion when last version is deleted Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com> (cherry picked from commit 1f43b28) Co-authored-by: Bhavana Ramaram <rbhavna@amazon.com> Signed-off-by: TrungBui59 <bui23@purdue.edu>
austintlee
pushed a commit
to austintlee/ml-commons
that referenced
this pull request
Feb 29, 2024
…h-project#1444) (opensearch-project#1523) * fix model group auto-deletion when last version is deleted Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com> (cherry picked from commit 1f43b28) Co-authored-by: Bhavana Ramaram <rbhavna@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when the last version of a model group is being deleted, the model group also gets deleted automatically along with the version. Due to this, the access control information stored in model group is getting deleted without user's knowledge and user is required to create a new model group which is undesirable. With this PR, we ensure even if the last existing version of a model group is deleted, the model group still remains without getting deleted.
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.